From 926788ff9a2e3b34d1a6445d3a68ce7c614ef615 Mon Sep 17 00:00:00 2001 From: Anton Khorev Date: Sun, 5 May 2024 17:14:37 +0300 Subject: [PATCH] Remove tests for message paths without ids These tests don't fail because they reuse ids from previous requests. --- test/controllers/messages_controller_test.rb | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/test/controllers/messages_controller_test.rb b/test/controllers/messages_controller_test.rb index dfec6346f..fd4a5ed10 100644 --- a/test/controllers/messages_controller_test.rb +++ b/test/controllers/messages_controller_test.rb @@ -263,10 +263,6 @@ class MessagesControllerTest < ActionDispatch::IntegrationTest end assert Message.find(unread_message.id).message_read - # Asking to reply to a message with no ID should fail - get message_reply_path - assert_response :success - # Asking to reply to a message with a bogus ID should fail get message_reply_path(:message_id => 99999) assert_response :not_found @@ -313,10 +309,6 @@ class MessagesControllerTest < ActionDispatch::IntegrationTest assert_select "a[href='#{user_path user}']", :text => user.display_name assert Message.find(unread_message.id).message_read - # Asking to read a message with no ID should fail - get message_path - assert_response :success - # Asking to read a message with a bogus ID should fail get message_path(:id => 99999) assert_response :not_found @@ -417,10 +409,6 @@ class MessagesControllerTest < ActionDispatch::IntegrationTest assert_response :see_other assert_not Message.find(unread_message.id).message_read - # Asking to mark a message with no ID should fail - post message_mark_path - assert_redirected_to inbox_messages_path - # Asking to mark a message with a bogus ID should fail post message_mark_path(:message_id => 99999) assert_response :not_found @@ -467,10 +455,6 @@ class MessagesControllerTest < ActionDispatch::IntegrationTest assert_not m.from_user_visible assert m.to_user_visible - # Asking to destroy a message with no ID should fail - delete message_path - assert_redirected_to inbox_messages_path - # Asking to destroy a message with a bogus ID should fail delete message_path(:id => 99999) assert_response :not_found -- 2.45.1